LCM-LoRA docs#5782
Merged
Merged
Conversation
patrickvonplaten
left a comment
patrickvonplaten
left a comment
Contributor
There was a problem hiding this comment.
Cool doc - just note that we already have some lcm-lora docs here:
https://github.com/huggingface/diffusers/blob/main/docs/source/en/using-diffusers/lcm.md
Shall we split all the docs on two sides (so remove what's already in LCM?)
and this doc page is currently not displayed because lcm_lora.md is not aded to _toctree: https://github.com/huggingface/diffusers/blob/main/docs/source/en/_toctree.yml
|
The documentation is not available anymore as the PR was closed or merged. |
Merged
Contributor
|
Could you transfer your code examples also directly to the model cards here: https://huggingface.co/latent-consistency |
stevhliu
approved these changes
Nov 15, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
reviewed
Nov 16, 2023
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Very cool and highly detailed!
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Contributor
Author
|
I've have addressed all the comments. Merging now |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* begin doc * fix examples * add in toctree * fix toctree * improve copy * improve introductions * add lcm doc * fix filename * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * address Sayak's comments * remove controlnet aux * open in colab * move to Specific pipeline examples * update controlent and adapter examples --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds docs for performing inference with LCM-LoRAs for most common pipelines/tasks. It removed the previous doc page and added two new docs in
tutorialssection. Let me know if this is the right section to put such docs @stevhliu @sayakpaul @patrickvonplaten